Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQRP-123 Rebranding #309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

anita-stanisz-sonarsource

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (SONARJNKNS-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

This plugin allows easy integration in Jenkins projects of [SonarQube](https://www.sonarsource.com/products/sonarqube/), the open-source solution for helping developers write [Clean Code](https://www.sonarsource.com/solutions/clean-code/?utm_medium=referral&utm_source=github&utm_campaign=clean-code&utm_content=sonar-scanner-jenkins).
This plugin allows easy integration in Jenkins projects of SonarQube ([Server](https://www.sonarsource.com/products/sonarqube/), [Cloud](https://www.sonarsource.com/products/sonarcloud/)) and [SonarQube Community Build](https://www.sonarsource.com/open-source-editions/sonarqube-community-edition/).

<picture>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the logo to be consistent with the other 'extensions'
Crosschecked with Rachel and the best is using the generic logo, and referring to the specific products in the text.

The logo is different depending on the mode.

@anita-stanisz-sonarsource anita-stanisz-sonarsource marked this pull request as ready for review January 7, 2025 14:32
* [Issue tracking](https://sonarsource.atlassian.net/jira/software/c/projects/SONARJNKNS/issues)

Documentation and changelog:
* [SonarQube Server](https://docs.sonarsource.com/sonarqube-server/latest/analyzing-source-code/scanners/jenkins-extension-sonarqube/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs the old version is referenced, apparently there is a manual process to update the source json. I'll make sure this is update after the release

Copy link
Contributor

@jacek-poreda-sonarsource jacek-poreda-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about wave logos which are stored here:

src/main/webapp/images

I guess we should update them as well

@anita-stanisz-sonarsource
Copy link
Author

Before and after updating logos
Screenshot from 2025-01-08 16-01-20
Screenshot from 2025-01-08 15-39-57

Copy link

sonarqube-next bot commented Jan 8, 2025

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants