Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQRP-123 Rebranding #309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,25 @@ SonarQube Scanner for Jenkins
[![Jenkins Plugin](https://img.shields.io/jenkins/plugin/v/sonar.svg)](https://plugins.jenkins.io/sonar)
[![Jenkins Plugin Installs](https://img.shields.io/jenkins/plugin/i/sonar.svg?color=blue)](https://plugins.jenkins.io/sonar)

This plugin allows easy integration in Jenkins projects of [SonarQube](https://www.sonarsource.com/products/sonarqube/), the open-source solution for helping developers write [Clean Code](https://www.sonarsource.com/solutions/clean-code/?utm_medium=referral&utm_source=github&utm_campaign=clean-code&utm_content=sonar-scanner-jenkins).
This plugin allows easy integration in Jenkins projects of SonarQube ([Server](https://www.sonarsource.com/products/sonarqube/), [Cloud](https://www.sonarsource.com/products/sonarcloud/)) and [SonarQube Community Build](https://www.sonarsource.com/open-source-editions/sonarqube-community-edition/).

<picture>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the logo to be consistent with the other 'extensions'
Crosschecked with Rachel and the best is using the generic logo, and referring to the specific products in the text.

The logo is different depending on the mode.

<source media="(prefers-color-scheme: dark)" srcset="./images/SonarQube_dark.png">
<img src="./images/SonarQube_light.png">
</picture>

SonarQube [Server](https://www.sonarsource.com/products/sonarqube/), [Cloud](https://www.sonarsource.com/products/sonarcloud/) and [SonarQube Community Build](https://www.sonarsource.com/open-source-editions/sonarqube-community-edition/) are widely used static analysis solutions for continuous code quality and security inspection.

They help developers detect coding issues in 30+ languages, frameworks, and IaC platforms, including Java, JavaScript, TypeScript, C#, Python, C, C++, and [many more](https://www.sonarsource.com/knowledge/languages/).

* [Documentation and changelog](https://docs.sonarsource.com/sonarqube/latest/analyzing-source-code/scanners/jenkins-extension-sonarqube/)
* [Issue tracking](https://sonarsource.atlassian.net/jira/software/c/projects/SONARJNKNS/issues)

Documentation and changelog:
* [SonarQube Server](https://docs.sonarsource.com/sonarqube-server/latest/analyzing-source-code/scanners/jenkins-extension-sonarqube/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs the old version is referenced, apparently there is a manual process to update the source json. I'll make sure this is update after the release

* [SonarQube Cloud](https://docs.sonarsource.com/sonarqube-cloud/advanced-setup/ci-based-analysis/sonarcloud-extension-for-jenkins/)
* [SonarQube Community Build](https://docs.sonarsource.com/sonarqube-community-build/analyzing-source-code/scanners/jenkins-extension-sonarqube/)


If you want to make changes, please clone the [Git repository](https://github.com/SonarSource/sonar-scanner-jenkins).

With this plugin, you can configure SonarQube instances and run a Sonar Scanner analysis in several ways:
Expand Down
Binary file added images/SonarQube_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/SonarQube_light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public String getIcon() {
return "";
}

return "/plugin/" + wrapper.getShortName() + "/images/waves_16x16.png";
return "/plugin/" + wrapper.getShortName() + "/images/SonarQube_Mark.png";
}

// non use interface methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public SonarProjectIconAction(SonarAnalysisAction buildInfo) {
public String getIconFileName() {
PluginWrapper wrapper = Jenkins.getInstanceOrNull().getPluginManager()
.getPlugin(SonarPlugin.class);
return "/plugin/" + wrapper.getShortName() + "/images/waves_48x48.png";
return "/plugin/" + wrapper.getShortName() + "/images/SonarQube_Mark.png";
}

@Override
Expand Down
Binary file added src/main/webapp/images/SonarQube_Mark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/main/webapp/images/waves_16x16.png
Binary file not shown.
Binary file removed src/main/webapp/images/waves_48x48.png
Binary file not shown.