Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Scheme #1

Merged
merged 15 commits into from
Jun 17, 2024
Merged

Data Scheme #1

merged 15 commits into from
Jun 17, 2024

Conversation

pauljohanneskraft
Copy link
Collaborator

Data Scheme

♻️ Current situation & Problem

Firestore will be used for storage of all the data that is synced between different apps in the Engage-HF system, including the web frontend and Android, iOS mobile apps. To seamlessly share data between them, the data scheme document defines how data is stored in Firestore.

⚙️ Release Notes

  • Added data scheme chapter to Readme.

📚 Documentation

This PR adds documentation regarding the scheme in which data is stored in Firestore.

✅ Testing

Nothing to test, since this PR makes no code changes.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer self-requested a review June 6, 2024 22:17
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work here @pauljohanneskraft!

I added some comments here. @vishnuravi would be great to get your input here as well and identify any missing elements based on your experience in ENGAGE-HF.

Next we can request a review from all other team members after that to get everyone on the same page.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 6, 2024
@PSchmiedmayer PSchmiedmayer requested a review from vishnuravi June 6, 2024 22:52
@PSchmiedmayer
Copy link
Member

@pauljohanneskraft Feel free to tag an other round of reviews from my side and resolve all addresses conversations once you have pushed an updated version & filled out the rest of the elements in the bottom sections.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review June 17, 2024 16:53
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauljohanneskraft Thank you for the work here!

Please feel free to merge the PR and create remaining issues in GitHub for missing pieces or unresolved conversations so we can address them step-by-step as we merge smaller PRs. Please tag the relevant people for feedback and input if we are missing anything.

@pauljohanneskraft pauljohanneskraft merged commit e6ed90a into main Jun 17, 2024
@pauljohanneskraft pauljohanneskraft deleted the data-scheme-doc branch June 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants