[FEAT/#86] 여행 생성 뷰 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jan 12, 2024
Comment on lines
177
to
189
| binding.btnCreateTripNext.setOnSingleClickListener { | ||
| //다음으로 넘어감 | ||
| Intent(this, PreferenceTagActivity::class.java).apply { | ||
| putExtra(NAME, viewModel.name.value) | ||
| putExtra(START, viewModel.startYear.value) | ||
|
|
||
| putExtra(START, viewModel.startMonth.value) | ||
| putExtra(START, viewModel.startDay.value) | ||
| putExtra(END, viewModel.endYear.value) | ||
| putExtra(END, viewModel.endMonth.value) | ||
| putExtra(END, viewModel.endDay.value) | ||
| startActivity(this) | ||
| } | ||
| } |
There was a problem hiding this comment.
Intent에서 class를 넘겨줄때는 Parcelable을 적용해보는건 어떨까요?
There was a problem hiding this comment.
넵 구현 다 하고 적용해보겟습뉘다
leeeyubin
approved these changes
Jan 12, 2024
Comment on lines
+1
to
+4
| package com.going.presentation.enter | ||
|
|
||
| class FinishPreferenceActivity { | ||
| } |
There was a problem hiding this comment.
이 파일이 여행 입장할 때 쓰일 취향 태그 있는 액티비티인가용?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description