Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#86] 여행 생성 뷰 #91

Merged
merged 3 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package com.going.presentation.enter

class FinishPreferenceActivity {
}
Comment on lines +1 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일이 여행 입장할 때 쓰일 취향 태그 있는 액티비티인가용?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 맞숩니당

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.core.content.res.ResourcesCompat
import com.going.domain.entity.NameState
import com.going.presentation.R
import com.going.presentation.databinding.ActivityCreateTripBinding
import com.going.presentation.preferencetag.PreferenceTagActivity
import com.going.presentation.starttrip.StartTripSplashActivity
import com.going.ui.base.BaseActivity
import com.going.ui.extension.setOnSingleClickListener
Expand Down Expand Up @@ -174,9 +175,25 @@ class CreateTripActivity :

private fun initNextBtnClickListener() {
binding.btnCreateTripNext.setOnSingleClickListener {
//다음으로 넘어감
Intent(this, PreferenceTagActivity::class.java).apply {
putExtra(NAME, viewModel.name.value)
putExtra(START, viewModel.startYear.value)

putExtra(START, viewModel.startMonth.value)
putExtra(START, viewModel.startDay.value)
putExtra(END, viewModel.endYear.value)
putExtra(END, viewModel.endMonth.value)
putExtra(END, viewModel.endDay.value)
startActivity(this)
}
}
Comment on lines 177 to 189
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent에서 class를 넘겨줄때는 Parcelable을 적용해보는건 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 구현 다 하고 적용해보겟습뉘다

}

companion object {
const val NAME = "name"
const val START = "start"
const val END = "end"
}
}


Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent">

</androidx.constraintlayout.widget.ConstraintLayout>