Skip to content

Commit

Permalink
Updating comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ABenC377 committed Oct 24, 2024
1 parent e1427a0 commit 4fe1f2e
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 155 deletions.
68 changes: 0 additions & 68 deletions .github/actions/average_single_benchmark/action.yml

This file was deleted.

54 changes: 0 additions & 54 deletions .github/actions/run_individual_benchmark/action.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/actions/select_setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: setup armclang
description: installs dependencies and correct armclang version to build and test simeng

##############################################################################
# Calls the correct setup action based on parameters passed into this action;.
# Calls the correct setup action based on parameters passed into this action.
##############################################################################

inputs:
Expand Down
8 changes: 0 additions & 8 deletions .github/actions/setup_gcc_macos/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@ runs:
#######################################
# Build SimEng

# if [[ ${{ inputs.MODE }} == "Release" ]]; then
# cmake --build build -j $(sysctl -n hw.ncpu)
# else
# echo "cores: $(sysctl -n hw.ncpu)"
# cmake --build build -j 5
# fi

#######################################
- name: Build SimEng
shell: bash
Expand Down
14 changes: 3 additions & 11 deletions .github/actions/setup_gcc_ubuntu/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,8 @@ runs:
apt upgrade -y
#######################################
# Running this prevents gcc-10 on ubuntu 20 from segfaulting in unit tests for some reason
# (installs some packages, not sure which ones prevent failure, but it doesn't take long to run).
# Install GCC
#######################################
# - if: ${{ inputs.gcc-version == 'gcc-10' }}
# name: install llvm
# shell: bash
# run: |
# wget https://apt.llvm.org/llvm.sh
# chmod +x llvm.sh
# ./llvm.sh 14

- name: Install gcc
shell: bash
run: |
Expand All @@ -91,7 +82,8 @@ runs:
#######################################
# Build SimEng
# Then store the C compiler and CPP compiler as environmental variables to be used by LINUX_BUILD_TEST
# Then store the C compiler and CPP compiler as environmental variables to
# be used by LINUX_BUILD_TEST
#######################################
- name: Build SimEng
shell: bash
Expand Down
4 changes: 3 additions & 1 deletion .github/actions/simeng_benchmarks/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ runs:
steps:

##################################
# clones repo with different versions of the checkout action, as container has different node versions and some compilers run on older OSes that have differing node versions
# clones repo with different versions of the checkout action, as container
# has different node versions and some compilers run on older OSes that
# have differing node versions
##################################

- if: ${{ contains(fromJson('["ubuntu:18.04"]'), matrix.OS) }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/LINUX_BUILD_TEST.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs:

steps:
#######################################
# Clones repo to workspace. (ubuntu 18 is missing correct glibc version for newer checkout action version i.e. use older checkout version)
# Clones repo to workspace. (ubuntu 18 is missing correct glibc version
# for newer checkout action version i.e. use older checkout version)
# NOTE: may want to remove support for gcc-7 soon
#######################################
- if: ${{ contains(fromJson('["ubuntu:18.04"]'), matrix.OS) }}
Expand Down Expand Up @@ -161,5 +162,4 @@ jobs:
with:
BENCHMARK_BRANCH: ${{ env.BENCHMARK_BRANCH }}
OS: ${{ matrix.OS }}
PAT: ${{ env.PAT }}
##########################################
PAT: ${{ env.PAT }}
9 changes: 0 additions & 9 deletions .github/workflows/MAIN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,10 @@ name: "Build"
on:
workflow_dispatch:

# workflow_call:
# push:
# branches:
# - dev

pull_request:
branches:
- dev
- main


# schedule:
# - cron: '0 0 */6 * *' # Runs every 6 days

jobs:

Expand Down

0 comments on commit 4fe1f2e

Please sign in to comment.