Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing multiple markers selection with SAM #534

Closed
wants to merge 24 commits into from

Conversation

moontrip
Copy link
Contributor

@moontrip moontrip commented Oct 4, 2023

This PR intends to test multiple markers selection with SAM, thus branched out from https://github.com/VEuPathDB/web-monorepo/tree/431-multi-select-marker. It seems to work just fine.

I made this as a draft PR as I was not sure when this would be required and possible changes in the parent PR, #513, that may affect this work. You can test it if you are interested, @bobular 😄

@moontrip moontrip mentioned this pull request Oct 4, 2023
7 tasks
@moontrip moontrip requested a review from bobular October 4, 2023 21:16
…ch-out

Multiple marker selection branch out
@moontrip moontrip changed the base branch from 431-multi-select-marker to main November 1, 2023 03:51
@moontrip
Copy link
Contributor Author

moontrip commented Nov 1, 2023

@bobular New update is made with Dave's recent map refactor work. Please check the following comment for the details: #581 (comment).

And then, check this comment, #513 (comment)

@moontrip moontrip marked this pull request as ready for review November 1, 2023 03:54
@moontrip moontrip linked an issue Nov 2, 2023 that may be closed by this pull request
4 tasks
@moontrip
Copy link
Contributor Author

moontrip commented Nov 9, 2023

Since there are lots of changes made in #588, which was branched out from this PR, we will use that PR instead this, thus closing this PR.

@moontrip moontrip closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map - add multi-select clickable/highlightable markers to MapVEuMap component
2 participants