-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing multiple markers selection with SAM #534
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-out Multiple marker selection branch out
@bobular New update is made with Dave's recent map refactor work. Please check the following comment for the details: #581 (comment). And then, check this comment, #513 (comment) |
4 tasks
6 tasks
Since there are lots of changes made in #588, which was branched out from this PR, we will use that PR instead this, thus closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to test multiple markers selection with SAM, thus branched out from https://github.com/VEuPathDB/web-monorepo/tree/431-multi-select-marker. It seems to work just fine.
I made this as a draft PR as I was not sure when this would be required and possible changes in the parent PR, #513, that may affect this work. You can test it if you are interested, @bobular 😄