Multiple marker selection via BoundsDriftMarker and SemanticMarkers #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-out Multiple marker selection branch out
|
I've checked off the remaining items/made new tickets. We could merge this when it is disabled (see new checkbox item in description). |
2 tasks
address marker double-click
bobular
commented
Nov 13, 2023
| @@ -304,6 +308,7 @@ function MapLayerComponent(props: MapTypeMapLayerProps) { | |||
| if (markerDataResponse.error) | |||
| return <MapFloatingErrorDiv error={markerDataResponse.error} />; | |||
|
|
|||
| // pass selectedMarkers and its state function | |||
There was a problem hiding this comment.
Oops we need to get rid of this comment (and homologous ones in Bubble/Barplot mode)
dmfalke
approved these changes
Nov 13, 2023
4 tasks
….com/VEuPathDB/web-monorepo into multiple-marker-selection-simplified
….com/VEuPathDB/web-monorepo into map-marker-popup-highlight
…thDB/web-monorepo into map-marker-popup-highlight
Map marker popup highlight
|
I think we're in a relatively good place here, but we should not merge this before b66, which gives us time to address the remaining minor issues (minor to the user - major for us, probably!) |
…le-clicking a solution to prevent single click while double clicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: targets #534
Hi @moontrip and @dmfalke
I wanted to try my suggestion in #513 (comment) and I have found that it works pretty well and has removed quite a lot of code. I've also made it more 'reacty' and got rid of one jquery-like bit.
I have only sorted out the
@veupathdb/componentsside of things - and fixed all the stories (hopefully reverting the old marker stories back to what they were before, so only the MarkerSelection story has selectedMarker logic).I did introduce a
useEffectto do pruning onselectedMarkersbut I'd say this was OK. If you pan a selected marker off-screen, you would expect to trigger a side-effect maybe? Nothing is triggered if nothing needs pruning.I've changed the spec of
selectedMarkersback tostring[]as per the original spec.Some things to do
selectedMarkerswhich is likely related to marker churn inSemanticMarkers