Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add recursion depth limit in to_array_debug() #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add recursion depth limit in to_array_debug() #60

wants to merge 1 commit into from

Conversation

drdzyk
Copy link
Contributor

@drdzyk drdzyk commented Dec 20, 2022

No description provided.

@drdzyk drdzyk mentioned this pull request Dec 20, 2022
Open
tolk-vm
tolk-vm reviewed Jan 24, 2023
View reviewed changes
kphp_polyfills.php
if (is_object($v)) {
if ($depth++ > 64) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is $depth--?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@drdzyk drdzyk force-pushed the seismont/limit-recursion-in-to-array branch from 57ddfee to 0ebf0a4 Compare January 30, 2023 13:45
@drdzyk drdzyk requested a review from tolk-vm January 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolk-vm tolk-vm Awaiting requested review from tolk-vm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdzyk @tolk-vm