Fix cache logic #135
Merged
Fix cache logic #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As written, the cache is append only. This is incorrect as, with any Accept-CH header set, the entire cache should be overwritten with the new contents. #134 (comment)
miketaylr
reviewed
Dec 20, 2022
Co-authored-by: Mike Taylor <[email protected]>
miketaylr
approved these changes
Dec 21, 2022
github-actions bot
added a commit
that referenced
this pull request
Dec 21, 2022
SHA: ce95f52 Reason: push, by arichiv Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
domenic
pushed a commit
to WICG/nav-speculation
that referenced
this pull request
Jan 18, 2023
The "Client Hints Infrastructure" specification updated its cache logic in WICG/client-hints-infrastructure#135. This contains the corresponding updates for prerendering. Closes #232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, the cache is append only. This is incorrect as, with any Accept-CH header set, the entire cache should be overwritten with the new contents.
#134 (comment)
Preview | Diff