feat: updated dropdown to conditionally render selected sample template name onclick #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinyl-Davyl
force-pushed
the
template-name
branch
from
b967487 to
13959c8
Compare
Signed-off-by: Vinyl-Davyl <[email protected]>
|
@dselman @DianaLease @mttrbrts please review this when you’re available. Thanks |
|
Solved Issue #32 ✅ |
|
Can you please share a video / screenshot of the old and the new behavior? |
Sure, definitely would do that right away for clarity |
OLD: Notice the Load Sample Select drop on a sample template after load 1 Another Instance, The name of the loaded sample is not in any way being visible or indicated anywhere to show/clarify which load sample you're currently on NEW: New updates made. The sample name is now conditionally rendered on the drop down showing and Indicating each load sample clicked on the drop down conditionally, depending on the name of the sample 1 2 3 |
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
…ter loading experience Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
fixed favicon to accordproject icon Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Muskan Bararia <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.28 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.28...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Muskan Bararia <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.10 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Co-authored-by: Matt Roberts <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Bumps [crypto-js](https://github.com/brix/crypto-js) from 4.1.1 to 4.2.0. - [Commits](brix/crypto-js@4.1.1...4.2.0) --- updated-dependencies: - dependency-name: crypto-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
…ter loading experience Signed-off-by: Vinyl-Davyl <[email protected]>
sanketshevkar
approved these changes
May 28, 2024
|
@Vinyl-Davyl can you please fix the dco check? |
…ound into template-name
Signed-off-by: Muskan Bararia <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Muskan Bararia <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Co-authored-by: Matt Roberts <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
…ter loading experience Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
fixed favicon to accordproject icon Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
…ter loading experience Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Muskan Bararia <[email protected]>
Signed-off-by: Muskan Bararia <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]>
Signed-off-by: Vinyl-Davyl <[email protected]> Signed-off-by: Vinyl-Davyl <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.