Skip to content
Build

make the right comparaison for the PR results #66

Sign in to view logs

make the right comparaison for the PR results

make the right comparaison for the PR results #66

Triggered via pull request December 21, 2023 17:45
@adrienpessuadrienpessu
synchronize #30
23-make-a-diff-of-the-findings-in-the-pr-and-the-main-branch-to-focus-only-on-new-findings
Status Failure
Total duration 8m 12s
Artifacts 2

build.yml

on: pull_request
Build
1m 23s
Build
Test
1m 26s
Test
Inspect code
6m 30s
Inspect code
Verify plugin
3m 42s
Verify plugin
Release draft
0s
Release draft
Fit to window
Zoom out
Zoom in

Annotations

1 error, 9 warnings, and 24 notices
Verify plugin
Process completed with exit code 1.
Local 'var' is never modified and can be declared as 'val': build.gradle.kts#L127
Variable is never modified, so it can be declared using 'val'
Incorrect string capitalization: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L20
String 'GHE Hostname' is not properly capitalized. It should have sentence capitalization
Incorrect string capitalization: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L21
String 'GHE Token' is not properly capitalized. It should have sentence capitalization
Redundant SAM constructor: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L305
Redundant SAM-constructor
Redundant SAM constructor: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L252
Redundant SAM-constructor
Unused symbol: src/main/kotlin/com/github/adrienpessu/sarifviewer/utils/Icons.kt#L3
Class "Icons" is never used
Unused symbol: src/main/kotlin/com/github/adrienpessu/sarifviewer/utils/Icons.kt#L6
Property "ICON_WARNING" is never used
Unused symbol: src/main/kotlin/com/github/adrienpessu/sarifviewer/MyBundle.kt#L10
Object "MyBundle" is never used
Unused symbol: src/main/kotlin/com/github/adrienpessu/sarifviewer/utils/Icons.kt#L8
Property "ERROR" is never used
Return or assignment can be lifted out: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/BranchItemComboBox.kt#L11
'Return' can be lifted out of 'if'
Object literal can be converted to lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L343
Convert to lambda
Object literal can be converted to lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L211
Convert to lambda
Object literal can be converted to lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L107
Convert to lambda
Object literal can be converted to lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L219
Convert to lambda
Object literal can be converted to lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L276
Convert to lambda
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L17
Property name `sarif_id` should not contain underscores
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L8
Property name `analysis_key` should not contain underscores
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L12
Property name `created_at` should not contain underscores
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L14
Property name `rules_count` should not contain underscores
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L7
Property name `commit_sha` should not contain underscores
Property naming convention: src/main/kotlin/com/github/adrienpessu/sarifviewer/models/Root.kt#L13
Property name `results_count` should not contain underscores
Unnecessary parentheses in function call with lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L252
Unnecessary parentheses in function call with lambda
Unnecessary parentheses in function call with lambda: src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt#L305
Unnecessary parentheses in function call with lambda
Can be replaced with binary operator: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/Settings.kt#L36
Call can be replaced with binary operator
Can be replaced with binary operator: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/Settings.kt#L37
Call can be replaced with binary operator
Can be replaced with binary operator: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/Settings.kt#L35
Call can be replaced with binary operator
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L44
Use of getter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L48
Use of getter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L23
Use of getter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L56
Use of setter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L52
Use of setter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L36
Use of getter method instead of property access syntax
Accessor call that can be replaced with property access syntax: src/main/kotlin/com/github/adrienpessu/sarifviewer/configurable/SettingComponent.kt#L40
Use of setter method instead of property access syntax

Artifacts

Produced during runtime
Name Size
SARIF-viewer-0.0.8 Expired
1.88 MB
pluginVerifier-result Expired
11.4 KB