Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cleanup comments, unused vars, config files. #114

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: Cleanup comments, unused vars, config files. #114

merged 2 commits into from
Jan 23, 2024
+175 −177

Conversation

adam-alchemy
Copy link
Contributor

Motivation

There are some small things we should clean up prior to launch.

Solution

  • Update references of solc v0.8.21 to v0.8.22.
    • Verified the documentation links still contain the relevant info.
  • Remove two duplicate spaces in the license header.
  • Fix some comment verbage in AccountStorageV1.
  • Remove the unused errors AuthorizeUpgradeReverted and UnableToRemove.
  • Remove reference to permitted call hooks in IAccountInitializable.
  • Update slither.config.json to also filter out tests.

@adam-alchemy adam-alchemy requested a review from jaypaik January 23, 2024 18:08
jaypaik
jaypaik reviewed Jan 23, 2024
View reviewed changes
script/Deploy.s.sol
@@ -9,10 +9,10 @@
// option) any later version.
//
// This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
// implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2 spaces after a period is common in legal writing, and I assume that's why it was written this way. I'm fine with this change and I don't think legal would mind.

@adam-alchemy adam-alchemy merged commit 4199f10 into audit-2023-11-20 Jan 23, 2024
3 checks passed
@adam-alchemy adam-alchemy deleted the adam/cleanup branch January 23, 2024 19:39
jaypaik pushed a commit that referenced this pull request Jan 25, 2024
@adam-alchemy @jaypaik
fix: Cleanup comments, unused vars, config files. (#114)
c61cac5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypaik jaypaik jaypaik left review comments

@fangting-alchemy fangting-alchemy fangting-alchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adam-alchemy @jaypaik @fangting-alchemy @adamegyed