Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: forge fmt and update foundry version in CI #37

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

adam-alchemy
Copy link
Contributor

@adam-alchemy adam-alchemy commented Jan 5, 2024

Motivation

Per a recent foundry update, forge fmt changed how it indents enums in the two interfaces

Solution

Update the forge version pinned in the GitHub actions CI to the latest nightly tag.

Run forge fmt.

@adam-alchemy adam-alchemy requested a review from jaypaik January 5, 2024 17:15
@adam-alchemy adam-alchemy changed the title style: forge fmt style: forge fmt and update foundry version in CI Jan 5, 2024
@@ -7,6 +7,7 @@ interface IMultiOwnerPlugin {
enum FunctionId {
RUNTIME_VALIDATION_OWNER_OR_SELF, // require owner or self access
USER_OP_VALIDATION_OWNER // require owner access

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is weird (I guess the inline comment triggers it?). Oh well.

@jaypaik jaypaik merged commit be5f7d1 into audit-2023-11-20 Jan 7, 2024
3 checks passed
@jaypaik jaypaik deleted the adam/fix-fmt branch January 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants