Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: forge fmt and update foundry version in CI #37

Merged
merged 3 commits into from
Jan 7, 2024
Merged

style: forge fmt and update foundry version in CI #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea5bc95
forge fmt
adamegyed Jan 5, 2024
924b275
Remove foundry version pin in CI workflow
adamegyed Jan 5, 2024
a2dab03
Add back explicit foundry version tags at latest
adamegyed Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly-5be158ba6dc7c798a6f032026fe60fc01686b33b
version: nightly-6fc74638b797b8e109452d3df8e26758f86f31fe

- name: "Install Pnpm"
uses: "pnpm/action-setup@v2"
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly-5be158ba6dc7c798a6f032026fe60fc01686b33b
version: nightly-6fc74638b797b8e109452d3df8e26758f86f31fe

- name: Install forge dependencies
run: forge install
Expand All @@ -95,7 +95,7 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly-5be158ba6dc7c798a6f032026fe60fc01686b33b
version: nightly-6fc74638b797b8e109452d3df8e26758f86f31fe

- name: Install forge dependencies
run: forge install
Expand Down
1 change: 1 addition & 0 deletions src/plugins/owner/IMultiOwnerPlugin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ interface IMultiOwnerPlugin {
enum FunctionId {
RUNTIME_VALIDATION_OWNER_OR_SELF, // require owner or self access
USER_OP_VALIDATION_OWNER // require owner access

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is weird (I guess the inline comment triggers it?). Oh well.

}

/// @notice This event is emitted when owners of the account are updated.
Expand Down
4 changes: 3 additions & 1 deletion src/plugins/session/ISessionKeyPlugin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import {Call} from "../../interfaces/IStandardExecutor.sol";
import {UserOperation} from "../../interfaces/erc4337/UserOperation.sol";

interface ISessionKeyPlugin {
enum FunctionId {USER_OP_VALIDATION_SESSION_KEY}
enum FunctionId {
USER_OP_VALIDATION_SESSION_KEY
}

error InvalidSessionKey(address sessionKey);
error NotAuthorized(address caller);
Expand Down