Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix PRs with only deleted files running all spread tests from all systems on each system #14965

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maykathm
Copy link
Contributor

@maykathm maykathm commented Jan 23, 2025

When PRs' only changes are deleted files, those changes are not detected, causing the spread filter to fail and all spread tests from all systems to run on every system.

Changes

  • Update changed-files action: it was far behind the current release
  • Include deleted files in changed files (the purpose of this addition is so that if the only change is deleting a spread test, then no spread tests will be run)
  • If the changes continue to remain empty, then do not call the spread filter and just run all tests on the current system

@maykathm maykathm changed the title changed-files bump and don't use filter with no changed files tests: fix PRs with only deleted files running all spread tests from all systems on each system Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Thu Jan 23 17:19:16 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/12928717632

Failures:

Preparing:

  • openstack:fedora-40-64:tests/main/interfaces-network-control-ip-netns
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-tumbleweed-64:tests/main/snapd-homedirs

Executing:

  • google-distro-1:amazon-linux-2023-64:tests/main/auto-refresh-gating
  • openstack:opensuse-tumbleweed-64:tests/main/snap-refresh-hold
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close_mid_restart
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating-from-snap
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:parallel
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:restart
  • openstack:opensuse-15.6-64:tests/main/refresh:parallel_strict_remote
  • openstack:opensuse-tumbleweed-64:tests/main/snapd-snap-auto-install
  • openstack:opensuse-15.6-64:tests/main/refresh:strict_remote
  • openstack:opensuse-15.6-64:tests/main/snapd-snap-auto-install
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google:ubuntu-18.04-64:tests/unit/go:clang

Restoring:

  • openstack:fedora-40-64:tests/main/snap-system-key
  • openstack:fedora-40-64:tests/main/
  • openstack:fedora-40-64
  • openstack:fedora-40-64:tests/main/interfaces-network-control-ip-netns
  • openstack:fedora-40-64:tests/main/
  • openstack:fedora-40-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-tumbleweed-64:tests/main/snapd-snap-auto-install
  • openstack:opensuse-15.6-64:tests/main/snapd-snap-auto-install
  • openstack:opensuse-15.6-64:tests/main/system-usernames-install-twice
  • openstack:opensuse-15.6-64:tests/main/
  • openstack:opensuse-15.6-64
  • openstack:opensuse-tumbleweed-64:tests/main/snapd-homedirs
  • openstack:opensuse-tumbleweed-64:tests/main/
  • openstack:opensuse-tumbleweed-64
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google-arm:ubuntu-core-22-arm-64:tests/core/
  • google-arm:ubuntu-core-22-arm-64

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@dc7d81f). Learn more about missing BASE report.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14965   +/-   ##
=========================================
  Coverage          ?   78.27%           
=========================================
  Files             ?     1158           
  Lines             ?   153533           
  Branches          ?        0           
=========================================
  Hits              ?   120174           
  Misses            ?    25951           
  Partials          ?     7408           
Flag Coverage Δ
unittests 78.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants