Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix PRs with only deleted files running all spread tests from all systems on each system #14965

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests: fix PRs with only deleted files running all spread tests from all systems on each system #14965

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dd6bcb
changed-files bump and don't use filter with no changed files
maykathm Jan 23, 2025
18399fb
tests: chnaged from all_changed_files to all_modified_files
maykathm Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/spread-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,14 @@ jobs:

- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v41.0.0
uses: tj-actions/changed-files@v45.0.6

- name: Save changes files
run: |
CHANGED_FILES="${{ steps.changed-files.outputs.all_changed_files }}"
if [ -z "$CHANGED_FILES" ]; then
CHANGED_FILES="${{ steps.changed-files.outputs.deleted_files }}"
maykathm marked this conversation as resolved.
Show resolved Hide resolved
fi
echo "CHANGED_FILES=$CHANGED_FILES" >> $GITHUB_ENV
echo "The changed files found are: $CHANGED_FILES"

Expand All @@ -142,7 +145,7 @@ jobs:
# The tests are just filtered when the change is a PR
# When 'Run Nested' label is added in a PR, all the nested tests have to be executed
TASKS_TO_RUN=""
if [ -z "${{ github.event.number }}" ] || [ "$RUN_NESTED" = 'true' ] || [ -z "${{ inputs.rules }}" ]; then
if [ -z "${{ github.event.number }}" ] || [ "$RUN_NESTED" = 'true' ] || [ -z "${{ inputs.rules }}" ] || [ -z "$changes_param" ]; then
for TASKS in ${{ inputs.tasks }}; do
TASKS_TO_RUN="$TASKS_TO_RUN $prefix:$TASKS"
done
Expand Down
Loading