Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: larger negative peak and zoom out #2800

Merged
merged 3 commits into from
Dec 13, 2023
+92 −87

fix: negative peak picking

0a5924c
Select commit
Loading
Failed to load commit list.
Merged

fix: larger negative peak and zoom out #2800

fix: negative peak picking
0a5924c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 13, 2023 in 0s

0.00% of diff hit (target 2.10%)

View this Pull Request on Codecov

0.00% of diff hit (target 2.10%)

Annotations

Check warning on line 10 in src/component/1d/tool/PeakPointer.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/tool/PeakPointer.tsx#L10 

Added line #L10 was not covered by tests

Check warning on line 53 in src/component/1d/tool/PeakPointer.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/tool/PeakPointer.tsx#L53 

Added line #L53 was not covered by tests

Check warning on line 63 in src/component/1d/tool/PeakPointer.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/tool/PeakPointer.tsx#L60-L63 

Added lines #L60 - L63 were not covered by tests

Check warning on line 55 in src/component/1d/utilities/scale.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/utilities/scale.ts#L45-L55 

Added lines #L45 - L55 were not covered by tests

Check warning on line 57 in src/component/1d/utilities/scale.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/utilities/scale.ts#L57 

Added line #L57 was not covered by tests

Check warning on line 61 in src/component/1d/utilities/scale.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/1d/utilities/scale.ts#L59-L61 

Added lines #L59 - L61 were not covered by tests

Check warning on line 49 in src/component/hooks/useToolsFunctions.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/hooks/useToolsFunctions.ts#L49 

Added line #L49 was not covered by tests

Check warning on line 66 in src/component/hooks/useToolsFunctions.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/hooks/useToolsFunctions.ts#L66 

Added line #L66 was not covered by tests

Check warning on line 24 in src/component/reducer/actions/PeaksActions.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/reducer/actions/PeaksActions.ts#L24 

Added line #L24 was not covered by tests

Check warning on line 76 in src/component/reducer/actions/PeaksActions.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/reducer/actions/PeaksActions.ts#L76 

Added line #L76 was not covered by tests

Check warning on line 110 in src/component/reducer/actions/PeaksActions.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/reducer/actions/PeaksActions.ts#L110 

Added line #L110 was not covered by tests

Check warning on line 64 in src/component/reducer/helper/Zoom1DManager.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/reducer/helper/Zoom1DManager.ts#L64 

Added line #L64 was not covered by tests

Check warning on line 92 in src/component/toolbar/FunctionToolBar.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/toolbar/FunctionToolBar.tsx#L91-L92 

Added lines #L91 - L92 were not covered by tests

Check warning on line 32 in src/component/utility/getClosePeak.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/utility/getClosePeak.ts#L2-L32 

Added lines #L2 - L32 were not covered by tests

Check warning on line 31 in src/component/utility/maxAbsoluteValue.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/component/utility/maxAbsoluteValue.ts#L2-L31 

Added lines #L2 - L31 were not covered by tests
View more details on Codecov