Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui input submit #809

Merged
merged 16 commits into from
Nov 2, 2023
Merged

feat: ui input submit #809

merged 16 commits into from
Nov 2, 2023

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Oct 27, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a0609c
Status: ✅  Deploy successful!
Preview URL: https://82c8de13.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-ui-input-submit.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-input-submit/dcl-sdk-7.3.27-6730261210.commit-246ac12.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-input-submit/dcl-sdk-commands-7.3.27-6730261210.commit-246ac12.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-input-submit/@dcl/inspector/dcl-inspector-7.3.27-6730261210.commit-246ac12.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/ui-input-submit-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/ui-input-submit

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b8ca94) 70.52% compared to head (9a0609c) 70.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   70.52%   70.55%   +0.03%     
==========================================
  Files         399      399              
  Lines       13114    13128      +14     
  Branches     1715     1723       +8     
==========================================
+ Hits         9248     9262      +14     
  Misses       3652     3652              
  Partials      214      214              
Files Coverage Δ
...ages/@dcl/react-ecs/src/components/Input/index.tsx 100.00% <ø> (ø)
packages/@dcl/react-ecs/src/reconciler/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pravusjif
Copy link
Member Author

Protocol package will be updated to point to its main package after this PR is approved.

@pravusjif pravusjif requested a review from gonpombo8 October 30, 2023 21:03
@pravusjif pravusjif marked this pull request as ready for review October 30, 2023 21:03
@gonpombo8 gonpombo8 force-pushed the feat/ui-input-submit branch from 640a60a to a74c826 Compare November 1, 2023 15:36
@gonpombo8 gonpombo8 enabled auto-merge (squash) November 1, 2023 15:55
@pravusjif pravusjif merged commit f58fd69 into main Nov 2, 2023
9 of 10 checks passed
@pravusjif pravusjif deleted the feat/ui-input-submit branch November 2, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants