Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sdk7 ui input submit #5864

Merged
merged 12 commits into from
Nov 2, 2023
Merged

feat: sdk7 ui input submit #5864

merged 12 commits into from
Nov 2, 2023

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Oct 27, 2023 •
edited
Loading

  • Added new NavigationSubmitEvent to UiInput's TextField VisualElement to output a UiInpuResult component with the new isSubmit bool in true. Allowed keys for submitting are only Return/Enter and keypad's Return/Enter.
  • Added textfield clearing on submit
  • Fixed and re-enabled some Ui component tests including UiInput

NOTE: The PR is actually quite small, had many file changes due to some test assemblies I had to update.

Related PRs

QA TEST INSTRUCTIONS

  1. Enter this playground link
  2. Wait until the world loads and hit the RUN button
  3. Write something in the text input and hit ENTER/RETURN
  4. Open the browser console (F12) and check that what you wrote is displayed in a console log

@pravusjif pravusjif self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

After the CI passes:

Web

This branch can be previewed at:

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

SDK 6/7:

More

@pravusjif pravusjif mentioned this pull request Oct 27, 2023
Merged
@pravusjif pravusjif mentioned this pull request Oct 27, 2023
Merged
@pravusjif pravusjif added the do not merge This PR should not be merged because is experimental or for testing purposes. label Oct 30, 2023
@pravusjif
Copy link
Member Author

Protocol package will be updated to point to its main package after this PR is approved.

@pravusjif pravusjif removed the do not merge This PR should not be merged because is experimental or for testing purposes. label Oct 30, 2023
@pravusjif pravusjif marked this pull request as ready for review October 30, 2023 21:33
@pravusjif pravusjif requested a review from a team as a code owner October 30, 2023 21:33
Ludmilafantaniella
Ludmilafantaniella approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA

Screen.Recording.2023-10-30.at.18.46.56.mov

@pravusjif pravusjif removed request for lorux0 and a team October 31, 2023 10:43
@pravusjif pravusjif merged commit e29d9d3 into dev Nov 2, 2023
1 check passed
@pravusjif pravusjif deleted the feat/sdk7-ui-input-submit branch November 2, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@mikhail-dcl mikhail-dcl mikhail-dcl approved these changes

Assignees

@pravusjif pravusjif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pravusjif @mikhail-dcl @Ludmilafantaniella