Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: fresh guest getting 0% loading when entering world / emotes failing to load or never reporting failure #6047

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

dalkia
Copy link
Contributor

@dalkia dalkia commented Jan 9, 2024

What does this PR change?

Hotfix PR

How to test the changes?

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@dalkia dalkia force-pushed the hotfix/guest-stuck-in-loading branch from d47cba4 to 9b4edba Compare January 9, 2024 13:57
Fixed emotes failing to load or never reporting failure
@dalkia dalkia changed the title hotfix: fresh guest getting 0% loading when entering world hotfix: fresh guest getting 0% loading when entering world / emotes failing to load or never reporting failure Jan 9, 2024
@dalkia dalkia changed the base branch from dev to main January 9, 2024 14:00
@anicalbano anicalbano self-requested a review January 9, 2024 14:54
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Both fixes are working as expected. You can check the evidence in these videos:

09.01.2024_11.45.47_REC.mp4
09.01.2024_11.50.58_REC.mp4

@anicalbano anicalbano added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 1783590 Jan 9, 2024
15 checks passed
@anicalbano anicalbano deleted the hotfix/guest-stuck-in-loading branch January 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants