Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java23: Thread.suspend() and Thread.resume(), etc. have been removed #18758

Closed
keithc-ca opened this issue Jan 15, 2024 · 4 comments
Closed

Java23: Thread.suspend() and Thread.resume(), etc. have been removed #18758

keithc-ca opened this issue Jan 15, 2024 · 4 comments

Comments

@keithc-ca
Copy link
Contributor

Failure link

Test code no longer compiles against the head stream:

The upstream change

Failure output (captured from console output)

10:27:04      [javac] /home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_aarch64_linux_Personal_testList_0/aqa-tests/functional/Java8andUp/src/org/openj9/test/java/lang/Test_Thread.java:723: error: cannot find symbol
10:27:04      [javac] 				ct.suspend();
10:27:04      [javac] 				  ^
10:27:04      [javac]   symbol:   method suspend()
10:27:04      [javac]   location: variable ct of type Thread
@pshipton
Copy link
Member

@llxia is there somebody who can fix this?

@llxia
Copy link
Contributor

llxia commented Jul 15, 2024

@LongyuZhang could you please take a look? Thanks

@keithc-ca
Copy link
Contributor Author

I think we may have arrived at the point where it makes sense to use the Java preprocessor on test code as well so the effects of API differences like this can simply be encapsulated like this:

/*[IF JAVA_SPEC_VERSION < 23]*/
// tests that depend upon API removed in Java 23
/*[ENDIF] JAVA_SPEC_VERSION 23 */

@pshipton
Copy link
Member

Changes are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants