Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" #16

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" #16

merged 1 commit into from
Jul 30, 2024

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Jul 25, 2024 •
edited
Loading

@LongyuZhang
Copy link
Contributor Author

The copyright year has been updated. Thanks.

@LongyuZhang LongyuZhang mentioned this pull request Jul 25, 2024
Merged
@LongyuZhang
Copy link
Contributor Author

LongyuZhang commented Jul 25, 2024 •
edited
Loading

Test Links:
JDK23

  • Reproduce the error with re-build jdk: hyc_grinder_42329
  • Passed on alinux sanity.functional: hyc_grinder_42413
  • Passed on alinux extended.functional: hyc_grinder_42414
  • Passed on xlinux sanity.functional: hyc_grinder_42411
  • Passed on xlinux extended.functional: hyc_grinder_42415
    JDK21 for verify:
  • Passed on xlinux sanity.functional: hyc_grinder_42419
  • Passed on xlinux sanity.functional: hyc_grinder_42418
  • Passed on alinux sanity.functional: hyc_grinder_42416
  • Passed on alinux sanity.functional: hyc_grinder_42417
    @llxia Could you review it? Thanks.

@llxia
Copy link

llxia commented Jul 25, 2024

This is a revert of ibmruntimes/openj9-openjdk-jdk#729

@llxia
Copy link

llxia commented Jul 25, 2024

@LongyuZhang could you please push again to trigger Copyright check? Thanks

@LongyuZhang LongyuZhang force-pushed the thread1 branch 2 times, most recently from 567619e to e80e1f4 Compare July 25, 2024 14:58
@LongyuZhang LongyuZhang changed the title Fix thread and threadgroup tests in compile stage Fix thread and threadgroup tests in compile stage for jdk23 Jul 25, 2024
@LongyuZhang
Copy link
Contributor Author

@LongyuZhang could you please push again to trigger Copyright check? Thanks

Similar to ibmruntimes/openj9-openjdk-jdk#729 (comment), the copyright is appropriate given all the code is from upstream. Thanks.

@keithc-ca
Copy link
Member

This is a revert of ibmruntimes/openj9-openjdk-jdk#729

I think that should be the summary of this change.

@keithc-ca keithc-ca self-requested a review July 30, 2024 13:48
@LongyuZhang
Copy link
Contributor Author

This is a revert of ibmruntimes/openj9-openjdk-jdk#729

I think that should be the summary of this change.

Updated the description. Thanks.

@keithc-ca
Copy link
Member

Same comment here about commit message: ibmruntimes/openj9-openjdk-jdk#818 (comment).

@keithc-ca keithc-ca changed the title Fix thread and threadgroup tests in compile stage for jdk23 Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" Jul 30, 2024
@LongyuZhang
Copy link
Contributor Author

Same comment here about commit message: ibmruntimes/openj9-openjdk-jdk#818 (comment).

Updated the commit description as above. Thanks.

@keithc-ca
Copy link
Member

ibmruntimes/openj9-openjdk-jdk#818 (comment) applies here as well.

@LongyuZhang
Copy link
Contributor Author

ibmruntimes/openj9-openjdk-jdk#818 (comment) applies here as well.

Updated. Thanks.

@keithc-ca
Copy link
Member

Jenkins test sanity zlinux jdk23

@keithc-ca keithc-ca merged commit a78ac3e into ibmruntimes:openj9 Jul 30, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongyuZhang @llxia @keithc-ca