Extract Thread Test to JDK 22 and under #19918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Links:
JDK21 for verify:
|
llxia
reviewed
Jul 25, 2024
- Thread functions are removed for JDK 23, extract test to JDK 22 and under Signed-off-by: LongyuZhang <[email protected]>
llxia
approved these changes
Jul 29, 2024
keithc-ca
reviewed
Jul 30, 2024
Comment on lines
+115
to
+116
| <exclude name="${excludeJDK21UpGetThreadListStackTracesExtendedTest}" /> | ||
| <exclude name="${excludeJDK21UpGetThreadListStackTracesExtendedTest}" /> |
There was a problem hiding this comment.
Why two copies of the exclusion?
There was a problem hiding this comment.
Created PR #19940 to remove the duplicate exclusion. Thanks.
LongyuZhang
added a commit
to LongyuZhang/openj9
that referenced
this pull request
Jul 30, 2024
Remove the duplicate exclude for GetThreadListStackTracesExtendedTest Issue: eclipse-openj9#19918 Signed-off-by: LongyuZhang <[email protected]>
LongyuZhang
added a commit
to LongyuZhang/openj9
that referenced
this pull request
Jul 30, 2024
Remove the duplicate exclude for GetThreadListStackTracesExtendedTest. Issue: eclipse-openj9#19918 Signed-off-by: LongyuZhang <[email protected]>
LongyuZhang
added a commit
to LongyuZhang/openj9
that referenced
this pull request
Jul 30, 2024
Remove the duplicate exclude for GetThreadListStackTracesExtendedTest. Issue: eclipse-openj9#19918 (comment) Signed-off-by: LongyuZhang <[email protected]>
tajila
pushed a commit
to tajila/openj9
that referenced
this pull request
Jul 31, 2024
Remove the duplicate exclude for GetThreadListStackTracesExtendedTest. Issue: eclipse-openj9#19918 (comment) Signed-off-by: LongyuZhang <[email protected]>
keithc-ca
pushed a commit
to keithc-ca/openj9
that referenced
this pull request
Aug 2, 2024
Remove the duplicate exclude for GetThreadListStackTracesExtendedTest. Issue: eclipse-openj9#19918 (comment) Signed-off-by: LongyuZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue and PRs: Java23: Thread.suspend() and Thread.resume(), etc. have been removed #18758 Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" ibmruntimes/openj9-openjdk-jdk23#16 and Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729) ibmruntimes/openj9-openjdk-jdk#818