-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip methods with JvmtiMountTransition annotation in findDecompileInfo #17855
Conversation
Ah, |
Are the stack trace APIs not affected by the annotation? |
Java methods tagged with the JvmtiMountTransition annotation are involved in transitioning between carrier to virtual threads, and vice-versa. These methods are not part of the thread's scope. So, they are skipped during introspection by the following JVMTI functions: - ForceEarlyReturn - NotifyFramePop - Local Variable (GetOrSetLocal) This PR allows us to match the RI in jvmti/vthread/MethodExitTest. Related eclipse-openj9#17490 Closes eclipse-openj9#17758 Co-authored-by: Gengchen Tuo <[email protected]> Signed-off-by: Babneet Singh <[email protected]>
ed49e92
to
e7220c5
Compare
The |
There are stack trace APIs in JVMTI - the depth of frames will now not match (i.e. get a stack trace, find a method at depth 3, then try to use one of the APIs modified here, and fail because the depth is off due to an annotated method). |
jenkins test sanity alinux64 jdk21 |
Yes. We will need to apply this change to all places where Previously, I confused it with the Java stack trace APIs. |
Java methods tagged with the JvmtiMountTransition annotation are
involved in transitioning between carrier to virtual threads, and
vice-versa.
These methods are not part of the thread's scope. So, they are skipped
during introspection by the following JVMTI functions:
This PR allows us to match the RI in
jvmti/vthread/MethodExitTest
.Related #17490
Closes #17758