Downgrade isIndexableDataAddrPresent to BOOLEAN #20804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectively this was already a boolean, just taking more space than necessary. Thus compiler will be able to better pack 2 consecutive booleans (isIndexableDataAddrPresent and isVirtualLargeObjectHeapEnabled) Signed-off-by: Aleksandar Micic <[email protected]>
|
jenkins test stability zLinux jdk21 |
|
jenkins compile aix,win jdk8 |
tajila
approved these changes
Dec 10, 2024
|
@TobiAjila realized I misspelled sanity in 'jenkins test stability zLinux jdk21' |
|
Im happy with just compiles |
dmitripivkine
approved these changes
Dec 11, 2024
keithc-ca
reviewed
Jan 2, 2025
| @@ -5514,7 +5514,7 @@ typedef struct J9VMThread { | |||
| UDATA contiguousIndexableHeaderSize; | |||
| UDATA discontiguousIndexableHeaderSize; | |||
| #if defined(J9VM_ENV_DATA64) | |||
| UDATA isIndexableDataAddrPresent; | |||
| BOOLEAN isIndexableDataAddrPresent; | |||
There was a problem hiding this comment.
AuxFieldInfo29.dat should have been updated to be consistent with this change.
However, this may cause problems for DDR accessing older system dumps, particularly for big-ending systems if UDATA and BOOLEAN have different sizes.
There was a problem hiding this comment.
I see this was reverted by #20816 (without explanation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively this was already a boolean, just taking more space than necessary. Thus compiler will be able to better pack 2 consecutive booleans (isIndexableDataAddrPresent and
isVirtualLargeObjectHeapEnabled)