Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade isIndexableDataAddrPresent to BOOLEAN #20804

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Downgrade isIndexableDataAddrPresent to BOOLEAN #20804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtime/oti/j9nonbuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5514,7 +5514,7 @@ typedef struct J9VMThread {
UDATA contiguousIndexableHeaderSize;
UDATA discontiguousIndexableHeaderSize;
#if defined(J9VM_ENV_DATA64)
UDATA isIndexableDataAddrPresent;
BOOLEAN isIndexableDataAddrPresent;
Copy link
Contributor

@keithc-ca keithc-ca Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AuxFieldInfo29.dat should have been updated to be consistent with this change.

However, this may cause problems for DDR accessing older system dumps, particularly for big-ending systems if UDATA and BOOLEAN have different sizes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was reverted by #20816 (without explanation).

BOOLEAN isVirtualLargeObjectHeapEnabled;
#endif /* defined(J9VM_ENV_DATA64) */
void* gpInfo;
Expand Down Expand Up @@ -6074,7 +6074,7 @@ typedef struct J9JavaVM {
UDATA contiguousIndexableHeaderSize;
UDATA discontiguousIndexableHeaderSize;
#if defined(J9VM_ENV_DATA64)
UDATA isIndexableDataAddrPresent;
BOOLEAN isIndexableDataAddrPresent;
BOOLEAN isVirtualLargeObjectHeapEnabled;
BOOLEAN isIndexableDualHeaderShapeEnabled;
#endif /* defined(J9VM_ENV_DATA64) */
Expand Down