Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added machine translated hint to information_page.html #629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added machine translated hint to information_page.html #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions myhpi/core/templates/core/information_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ <h1 class="page-title">
</div>
<div class="col-lg-3">
<div class="side-panel-container">
{% get_language_info for LANGUAGE_CODE as lang %}
{% if lang.code == "en" %}
<aside class="side-panel border-accent">
This has page has been machine-translated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This has page has been machine-translated.
This page may have been machine-translated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better since other Gremien may actually manually translate it.

Also we could think about explaining it better. Why is it machine translated? What can I do about it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I don't think that a "may be machine translated" notice on all English pages provides any useful information. Can I trust this information? – Maybe.

Is there a reason why you prefer the "maybe" wording over my suggestion of making this configurable per page and provide reliable information ("is/is not machine translated")?

other Gremien may actually manually translate it

The FSR also translates some information pages by hand or at least reviews the automatic translation before publishing the page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that for a user, an explicit "is" would be more valuable.With the current specification of the issue I believe "may" is the best solution. This means I will be alerted to possible weirdness and know I will ask if something is unclear.

But if we expand the scope we can also have the is / is not . But I think this definitely needs to be set at the time of translation, automatically. So it may be more complicated, and I think this version would already be helpful (though the note may need to be expanded to explain a little better why the hint is therek

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think this definitely needs to be set at the time of translation

Yes, this should be set when translating a page

automatically

Only if it it still possible to change this. Otherwise, it would not be possible to machine-translate a page, review it (without any need for changes) and then publish it without a warning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if it it still possible to change this. Otherwise, it would not be possible to machine-translate a page, review it (without any need for changes) and then publish it without a warning.

Agreed. The question remains whether this PR (in some form, e.g. adapted wording ) is useful or not.

</aside>
{% endif %}
<aside class="side-panel border-accent">
<h1 class="side-panel-title">{% translate "Last edited" %}</h1>
{% if not page.last_published_at %}
Expand Down