Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deliver token when generated for the first time #121

Closed
wants to merge 1 commit into from
Closed

feat: deliver token when generated for the first time #121

wants to merge 1 commit into from

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Nov 3, 2023 •
edited by rolznz
Loading

@pavanjoshi914 pavanjoshi914 mentioned this pull request Nov 3, 2023
Merged
6 tasks
rolznz
rolznz approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz
Copy link
Contributor

rolznz commented Nov 4, 2023

Chatted with @pavanjoshi914 and @bumi and it seems more straightforward to keep as is, rather than relying on this side effect (especially when using the first token)

@rolznz rolznz closed this Nov 4, 2023
@rolznz rolznz mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavanjoshi914 @rolznz