Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Fix flag param handling in gevulot-cli #201

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix flag param handling in gevulot-cli #201

merged 1 commit into from
Jun 28, 2024

Conversation

tuommaki
Copy link
Contributor

No description provided.

@tuommaki tuommaki self-assigned this Jun 28, 2024
@tuommaki tuommaki merged commit e173d5d into main Jun 28, 2024
4 checks passed
@tuommaki tuommaki deleted the fix-flag-params branch June 28, 2024 13:46
@koxu1996
Copy link

This PR should not go unnoticed, as it introduced important workaround for passing single value args.

My case study

I wanted to pass foo -- bar args, so I used the following tasks' cmd_args when calling gevulot-cli exec

[{ "name": "foo", "value": "" }, { "name": "", "value": "--" }, { "name": "bar", "value": "" }]

Here is the request that was sent with CLI - request-1.json:

     ...
              "args": ["foo", "", "", "--", "bar", ""],
     ...

I was not expecting those empty strings 😿.

The solution was to update the CLI tool with cargo install --git https://github.com/gevulotnetwork/gevulot.git gevulot-cli (from #bbe20d41 to #700d759a).

Request after update - request-2.json:

     ...
              "args": ["foo", "--", "bar"],
     ...

Now everything works as expected!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants