-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Git Tips documentation for contributors #2315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorburger can you possibly incorporate the single-commit per review round point in bashir's doc: https://github.com/google/fhir-data-pipes/blob/master/doc/review_process.md? it's a great set of rules by the way we probably should incorporate most/all of them.
Done! Just pushed, plz have another look - better, like this? Merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for writing these tips Michael! I recognise this is of huge value to developers - and I'm also ok for us to iterate on this instead of dragging this out.
approved and fix/merge as you see fit. thanks!
@jingtang10 the other day in the meeting you suggested "sharing git know how" - here's a start, is this useful?
@omarismail94 and @fredhersch FYI