-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update git.md with more details about squash/amend commits #2617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying the PR workflow @vorburger.
Co-authored-by: Bashir Sadjad <[email protected]>
@jingtang10 my understanding, from comments above, is that you are cool with this; I'm therefore (exceptionally) "self merging" this now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @vorburger!
Co-authored-by: Jing Tang <[email protected]>
Co-authored-by: Jing Tang <[email protected]>
Co-authored-by: Jing Tang <[email protected]>
Co-authored-by: Jing Tang <[email protected]>
Co-authored-by: Jing Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great process. Just a nit, the fhir data pipes README has hyper links to git concepts like amend and squash etc.
Another nit, all the points start with 1. instead of 1,2,3
@joiskash Thank You!
If you would find this useful, would you like to raise a PR to proposing adding those? I'm happy to review it.
That's not a problem, and "normal", in Markdown syntax, as per https://spec.commonmark.org/0.31.2/#lists, quote: "The numbers of subsequent list items are disregarded." (i.e. autonumbered, by the "Markdown Processor"). Ergo, on https://google.github.io/android-fhir/contrib/git/ where it's "rendered" (as described here), it's correctly numbered, of course. I hope this helps to clarify? |
Sure!
Yes it does, thank you! I was looking for an example and the documentation on this. Thanks for sharing. |
Follow-up to #2315 (comment) ...