Add unit test for the EventStorageService #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WengerK
commented
Nov 29, 2018
WengerK
commented
Nov 29, 2018
Remove shipping as uncomplete tests, should be added in complete separated tests/PR.
Remove coupon as uncomplete tests, should be added in complete separated tests/PR.
…le_tag_manager into init-kernel-tests
This was referenced Nov 30, 2018
WengerK
commented
Nov 30, 2018
| * Asserts the events queue follows the FIFO (First in First out) pattern. | ||
| */ | ||
| public function testAddEventFifoQueue() { | ||
| $this->testAddEvent(); |
There was a problem hiding this comment.
Suggested change
| $this->testAddEvent(); |
useless
WengerK
commented
Nov 30, 2018
| * Asserts strictly same event aren't added twice in the events queue. | ||
| */ | ||
| public function testAddEventSameSkipped() { | ||
| $this->testAddEvent(); |
There was a problem hiding this comment.
Suggested change
| $this->testAddEvent(); |
useless
wanze
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here some basic tests.
They serve as Example for futur tests or as "code" example for developers which discover the module.
As I always say, people should read the tests to understand the module - thoses tests should help them - especially Units ones.
We still have to works on heavy tests (and more valuable for the module stability himself) as:
But let's merge first this in dev & then works separately on each other cases