Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for the CommerceEventsSubscriber #28

Merged
merged 9 commits into from
Dec 4, 2018

Conversation

WengerK
Copy link
Collaborator

@WengerK WengerK commented Nov 30, 2018

Should be merged & review after #18 as been merge.
Indeed, I branch from this PR to continue my work.

Copy link
Contributor

@wanze wanze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how you are writing tests, beside increasing test coverage they also serve as additional documentation. 😎Please merge! 👍

@WengerK WengerK merged commit b108ad5 into 8.x-1.x Dec 4, 2018
@WengerK WengerK deleted the cover-commerce-eventsubscriber branch December 4, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants