-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: pin to the latest approved workflows #29321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
added
pr/no-changelog
pr/no-milestone
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/1.18.x
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Jan 8, 2025
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 8, 2025
ryancragun
force-pushed
the
ryan/update-workflow-pins
branch
from
January 8, 2025 21:47
5e20df1
to
e5f62e7
Compare
CI Results: |
Build Results: |
ryancragun
force-pushed
the
ryan/update-workflow-pins
branch
from
January 9, 2025 16:39
e5f62e7
to
024b2da
Compare
ryancragun
force-pushed
the
ryan/update-workflow-pins
branch
from
January 21, 2025 19:21
024b2da
to
eaec65f
Compare
tvo0813
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the pipeline is passing.
ryancragun
force-pushed
the
ryan/update-workflow-pins
branch
from
January 24, 2025 17:23
eaec65f
to
025e5ef
Compare
The genesis of this PR is updating our cache action due to older actions being shut down[0]. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.[1] Since I was updating cache I went ahead and updated minor versions of all our actions. [0]: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down [1]: actions/cache#1510 Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
force-pushed
the
ryan/update-workflow-pins
branch
from
January 24, 2025 18:03
025e5ef
to
d1fe1b9
Compare
rebwill
approved these changes
Jan 24, 2025
6 tasks
ryancragun
added a commit
that referenced
this pull request
Jan 24, 2025
The genesis of this PR is updating our cache action due to older actions being shut down[0]. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.[1] Since I was updating cache I went ahead and updated minor versions of all our actions. [0]: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down [1]: actions/cache#1510 Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
added a commit
that referenced
this pull request
Jan 24, 2025
The genesis of this PR is updating our cache action due to older actions being shut down[0]. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.[1] Since I was updating cache I went ahead and updated minor versions of all our actions. [0]: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down [1]: actions/cache#1510 Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
added a commit
that referenced
this pull request
Jan 24, 2025
The genesis of this PR is updating our cache action due to older actions being shut down[0]. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.[1] Since I was updating cache I went ahead and updated minor versions of all our actions. [0]: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down [1]: actions/cache#1510 Signed-off-by: Ryan Cragun <[email protected]> Co-authored-by: Ryan Cragun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
backport/1.18.x
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
pr/no-milestone
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The genesis of this PR is updating our cache action due to older actions being shut down0. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.1
Since I was updating cache I went ahead and updated minor versions of all our actions.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.