Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix binary-size-check workflow #6552

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • cache_output not being set after a cache hit using restore key
  • Instead check for cache-matched-key != ''"

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain requested a review from a team as a code owner January 16, 2025 15:56
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (2ee8e4c) to head (f87ad3e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6552      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.02%     
==========================================
  Files         372      372              
  Lines       21371    21371              
==========================================
- Hits        20573    20570       -3     
- Misses        608      610       +2     
- Partials      190      191       +1     
Flag Coverage Δ
badger_v1 10.65% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.55% <ø> (ø)
cassandra-4.x-v2-auto 2.71% <ø> (ø)
cassandra-4.x-v2-manual 2.71% <ø> (ø)
cassandra-5.x-v1-manual 16.55% <ø> (ø)
cassandra-5.x-v2-auto 2.71% <ø> (ø)
cassandra-5.x-v2-manual 2.71% <ø> (ø)
elasticsearch-6.x-v1 20.34% <ø> (ø)
elasticsearch-7.x-v1 20.40% <ø> (ø)
elasticsearch-8.x-v1 20.57% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 2.77% <ø> (ø)
grpc_v1 12.16% <ø> (ø)
grpc_v2 9.04% <ø> (ø)
kafka-3.x-v1 10.33% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.78% <ø> (ø)
opensearch-1.x-v1 20.45% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 20.45% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.13% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title [CI] Fix cache hit output not being set after restoring cache using restore key [ci] Fix binary-size-check workflow Jan 17, 2025
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jan 17, 2025
@yurishkuro yurishkuro merged commit c36d588 into jaegertracing:main Jan 17, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants