-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation to keycloak-client #28
Conversation
@rmartinc Thanks! I have one small concern related to policy-enforcer javascript adapter. The JS adapter is still part of the main Keycloak repository and hence makes sense if it is still documented there. So can be better to either keep that one (file Copying the maven plugin from Keycloak is not so great, but IMO it is OK. Especially considering that it is relatively simple thing, which does not change too often and I don't see much better solutions for it, which are simple at the same time (anything more fancy can make things unnecessary complicated, so not sure if it worth it...) |
Yes, no problem, I simply moved the whole chapter. 😄 I will move back to the documentation. Then I ned to change two of the three PRs. |
@mposolda The policy-enforcer javascript adapter chapter has been maintained in the authorization services documentation and removed from the client. |
docs/maven-plugin/src/main/java/org/keycloak/guides/maven/GuideBuilder.java
Outdated
Show resolved
Hide resolved
docs/maven-plugin/src/main/java/org/keycloak/guides/maven/GuideBuilder.java
Outdated
Show resolved
Hide resolved
14e07dd
to
8bc0093
Compare
Thanks @stianst! All done! I have picked all the commits and done the manual changes. The final version attribute for the client is |
Closes #31870 Signed-off-by: rmartinc <[email protected]>
Rebased! It was needed. |
Moving the documentation to the keycloak-client. The idea is the commented chapters are moved to the new keycloak-client project as guides. The plugin used in keycloak is copied but removed the specific keycloak parts (it's simpler). I don't think this will be changed a lot.
In order to complete the issue we need two more PRs in different projects:
The new guides are generated in the keycloak-web as a new section:
And each section is just a normal guide (for example the first one):
Draft for the moment.