-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding keycloak-client guides #482
Conversation
@rmartinc Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be great to be able to support multiple categories within keycloak-client
, and allow mixing in guides from server repo and client repo into the same category.
For example keycloak-client
could use more than one category, put some guides into getting-started
some into securing apps
.
Version stuff works for now, but we'll most likely also want client release blog posts, so would need a way to enumerate all the client library versions for that. That should be in a follow-up though. |
Signed-off-by: rmartinc <[email protected]>
@stianst Changes requested done. I have also removed the system property and I'm using now the And yes, maybe we need to add versions for the client too. But we can do that when we need it. |
Do not merge until Keycloak client libraries have been released, and |
Incorporated in #494 - we just need to enable the client guides after the artifact is available. |
Adding the guides for keycloak-client. Main changes:
keycloak-client-guides
dependency to also obtain guides from that project.This cannot be merged until we have a real keycloak-client release (if you see I'm using the snapshot version). So tests are gonna fail for sure. Maybe we can change the
add-version.sh
to receive the keycloak version and the keycloak-client version (or guess it from the dependency? Don't know if possible). Draft because it cannot be merged yet.Check the PR in keycloak-client for images.
Related PRs:
@stianst @mposolda Take a look when you have time. It's just a first idea. The sample images are in the keycloak-client PR.