Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keycloak-client guides #482

Closed
wants to merge 1 commit into from
Closed

Conversation

rmartinc
Copy link
Contributor

Adding the guides for keycloak-client. Main changes:

  • It needs to download the new keycloak-client-guides dependency to also obtain guides from that project.
  • Images should also be retrieved from the new dependency.
  • I'm setting the version of the client as a system property. We can do something fancier but I think this is OK (it's just to know the version of client used, nothing more).

This cannot be merged until we have a real keycloak-client release (if you see I'm using the snapshot version). So tests are gonna fail for sure. Maybe we can change the add-version.sh to receive the keycloak version and the keycloak-client version (or guess it from the dependency? Don't know if possible). Draft because it cannot be merged yet.

Check the PR in keycloak-client for images.

Related PRs:

@stianst @mposolda Take a look when you have time. It's just a first idea. The sample images are in the keycloak-client PR.

@mposolda
Copy link
Contributor

@rmartinc Thanks!

Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be great to be able to support multiple categories within keycloak-client, and allow mixing in guides from server repo and client repo into the same category.

For example keycloak-client could use more than one category, put some guides into getting-started some into securing apps.

@stianst
Copy link
Contributor

stianst commented Aug 19, 2024

Version stuff works for now, but we'll most likely also want client release blog posts, so would need a way to enumerate all the client library versions for that. That should be in a follow-up though.

@rmartinc
Copy link
Contributor Author

@stianst Changes requested done. I have also removed the system property and I'm using now the ${properties["version.keycloak.client"]} to access the maven properties. This way we don't use any system property.

And yes, maybe we need to add versions for the client too. But we can do that when we need it.

@stianst stianst self-assigned this Aug 20, 2024
@stianst
Copy link
Contributor

stianst commented Aug 20, 2024

Do not merge until Keycloak client libraries have been released, and version.keycloak.client is updated in the pom.xml.

@stianst
Copy link
Contributor

stianst commented Sep 25, 2024

Incorporated in #494 - we just need to enable the client guides after the artifact is available.

@stianst stianst closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants