Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change command to apply manifests in the docs #10864

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Jun 4, 2024

Description of your changes:
Solves #10664

Checklist:

@google-oss-prow google-oss-prow bot requested review from chensun and zijianjoy June 4, 2024 11:18
Copy link

@rimolive: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test b30ca01 link false /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-upgrade-test b30ca01 link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipelines-samples-v2 b30ca01 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

hbelmiro commented Jun 4, 2024

It seems like we should update the docs as well. But maybe we should wait for kubeflow/website#3737 to get merged first.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 24424ba into kubeflow:master Jun 5, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants