-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: re-arrange my account dialog #2087
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 3.57% (-0.02% 🔻) |
97/2717 |
🔴 | Branches | 3.76% (-0.01% 🔻) |
61/1622 |
🔴 | Functions | 1.65% (-0.01% 🔻) |
15/908 |
🔴 | Lines | 3.63% (-0.02% 🔻) |
97/2673 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / KeypairInfoModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
17 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from d449f7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I create a new keypair, I can check my new keypair after refreshing. Can you make it possible to check right away after creating a new keypair?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24.03.0
or newer versionIn this PR, keypair in user account information has been moved to user settings menu, since keypair is not maintained by user, but only for admin, which may confuses user if the fields is remaining in user account modal.
Therefore, there are two things to check during this PR review:
Checklist: (if applicable)
Screenshot(s)