Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: re-arrange my account dialog #2087

Merged
merged 9 commits into from
Dec 8, 2023

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Dec 7, 2023

  • required Core version: 24.03.0 or newer version
    • You need to upgrade alembic version to the latest by executing the following command in Core directory:
       ./py -m alembic upgrade head
      

In this PR, keypair in user account information has been moved to user settings menu, since keypair is not maintained by user, but only for admin, which may confuses user if the fields is remaining in user account modal.
Therefore, there are two things to check during this PR review:

  • Check access key and secret key is removed from user information(so called "My Account" modal)
  • Check the new menu "My keypair Info" in user settings menu
  • Check all the keypairs of current user in "My keypair info modal"
  • Check the main access key tag is attached correctly.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Screenshot(s)

Screenshot 2023-12-07 at 6 41 56 PM Screenshot 2023-12-07 at 6 41 41 PM Screenshot 2023-12-07 at 7 36 14 PM

@lizable lizable requested a review from agatha197 December 7, 2023 10:57
@lizable lizable requested a review from yomybaby December 7, 2023 10:58
@lizable lizable added this to the 24.03 milestone Dec 7, 2023
@lizable lizable changed the title Feature/re arrange my account dialog feature: re-arrange my account dialog Dec 7, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2087.d3g9cs6u59b8lw.amplifyapp.com

@lizable lizable requested a review from inureyes December 7, 2023 11:05
Copy link

github-actions bot commented Dec 8, 2023

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
3.57% (-0.02% 🔻)
97/2717
🔴 Branches
3.76% (-0.01% 🔻)
61/1622
🔴 Functions
1.65% (-0.01% 🔻)
15/908
🔴 Lines
3.63% (-0.02% 🔻)
97/2673
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / KeypairInfoModal.tsx
0% 0% 0% 0%

Test suite run success

17 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from d449f7e

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a new keypair, I can check my new keypair after refreshing. Can you make it possible to check right away after creating a new keypair?

react/src/components/KeypairInfoModal.tsx Outdated Show resolved Hide resolved
react/src/components/KeypairInfoModal.tsx Outdated Show resolved Hide resolved
@lizable
Copy link
Contributor Author

lizable commented Dec 8, 2023

Just updated few things:

  • Refresh(fetching) keypair every time the modal opens.
  • Enlarge Keypair info modal to show both access key and secret key clearly, with out ellipsis.

Screenshot(s)

Screenshot 2023-12-08 at 12 38 48 PM

@lizable lizable requested a review from agatha197 December 8, 2023 03:49
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizable lizable merged commit cbd1892 into main Dec 8, 2023
7 checks passed
@lizable lizable deleted the feature/re-arrange-my-account-dialog branch December 8, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants