refactor: parsing image data for versions before 24.12 #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
2 tasks
agatha197
changed the title
3 tasks
agatha197
force-pushed
the
refactor/use-filterEmptyItem
branch
from
a7d80b1 to
226486e
Compare
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
0af5704 to
c19e56e
Compare
agatha197
added
type:refactor
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
c19e56e to
7cb84bf
Compare
6 tasks
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
7cb84bf to
6480068
Compare
yomybaby
changed the base branch from
refactor/use-filterEmptyItem
to
graphite-base/2817
yomybaby
force-pushed
the
graphite-base/2817
branch
from
226486e to
f758c59
Compare
yomybaby
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
6480068 to
9500252
Compare
yomybaby
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
9500252 to
3708a1b
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.02% (-0.01% 🔻) |
367/7314 |
| 🔴 | Branches | 4.41% (+0.02% 🔼) |
221/5013 |
| 🔴 | Functions | 2.94% (-0% 🔻) |
71/2411 |
| 🔴 | Lines | 4.92% (-0.01% 🔻) |
352/7153 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | helper/index.tsx | 50.97% (-1.35% 🔻) |
47.22% | 39.47% (-1.07% 🔻) |
52.24% (-1.61% 🔻) |
| 🔴 | hooks/index.tsx | 37.96% (-4.67% 🔻) |
24.39% (-3.39% 🔻) |
19.51% (-1.54% 🔻) |
37.31% (-4.7% 🔻) |
Test suite run success
100 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 4543a32
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
3708a1b to
1c990ef
Compare
6 tasks
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
3 times, most recently
from
775b8be to
f81d39c
Compare
yomybaby
requested changes
Nov 7, 2024
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
f81d39c to
afaa410
Compare
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
afaa410 to
a4f70a9
Compare
yomybaby
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
a4f70a9 to
3a506af
Compare
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
3 times, most recently
from
744604e to
7c8e7da
Compare
yomybaby
requested changes
Nov 12, 2024
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
7c8e7da to
46489c7
Compare
4 tasks
agatha197
force-pushed
the
refactor/parsing-image-data-before-2412
branch
2 times, most recently
from
c8306dd to
6993177
Compare
Merge activity
|
**Changes:** Refactored image handling similar to #2785 and #2795 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend. Key changes: - Consolidated separate tag components (BaseImageTags, ConstraintTags, LangTags) into a single ImageTags component - Simplified image metadata extraction by using string operations instead of complex parsing - Removed redundant language column and consolidated information into Tags column - Added new getTags utility function to consistently parse and format image tag information - Updated image search functionality to search through tag keys and values **Impact:** - Cleaner, more consistent display of image metadata in the UI - More maintainable code structure for handling image tags - Improved search capabilities across image metadata **Screenshots:**  **What to check:** Data parsing is the same as 24.12. **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: manager < 24.12 - [x] Specific setting for review: 10.100.64.15 - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after: will be handled in another stack
yomybaby
force-pushed
the
refactor/parsing-image-data-before-2412
branch
from
6993177 to
4543a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Refactored image handling similar to #2785 and #2795 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend.
Key changes:
Impact:
Screenshots:
What to check:
Data parsing is the same as 24.12.
Checklist: