-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: parsing image data in session launcher for before 24.12 #2818
refactor: parsing image data in session launcher for before 24.12 #2818
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
0af5704
to
c19e56e
Compare
28c8b39
to
9611d7d
Compare
c19e56e
to
7cb84bf
Compare
9611d7d
to
e12704a
Compare
7cb84bf
to
6480068
Compare
e12704a
to
b22b627
Compare
9500252
to
3708a1b
Compare
b22b627
to
e256c11
Compare
3708a1b
to
1c990ef
Compare
e256c11
to
6445e5b
Compare
1c990ef
to
ab1cca7
Compare
6445e5b
to
4f66088
Compare
ab1cca7
to
775b8be
Compare
4f66088
to
3f70242
Compare
775b8be
to
f81d39c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3a506af
to
71e0de8
Compare
38fc810
to
5cb9459
Compare
resolved! |
71e0de8
to
744604e
Compare
5cb9459
to
01d1980
Compare
744604e
to
7c8e7da
Compare
01d1980
to
b814fbf
Compare
7c8e7da
to
46489c7
Compare
b814fbf
to
162bc3b
Compare
46489c7
to
c8306dd
Compare
162bc3b
to
4f68e12
Compare
c8306dd
to
6993177
Compare
18df098
to
983a8a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
) **Changes:** Refactored image handling similar to #2800 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend. - Unified the display format of image information across components - Added base version and image tags display - Replaced custom tag display with standardized ImageTags component - Removed conditional rendering based on extended image info support **Rationale:** The changes provide a more uniform and informative way to display image metadata, making it easier for users to understand the characteristics of selected container images. **What to check:** Data parsing is the same as 24.12. **Effects:** Users will see: - Consistent image information display format - Clearer representation of image base versions - Standardized tag display across the interface - More detailed image metadata including architecture and labels **Screenshots:** ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/0a6100fd-d894-40d3-85d9-fe52961df2cf.png) **Checklist:** - [ ] Documentation - [ ] Test cases to verify image information display - [ ] Verify tag display functionality across different image types
6993177
to
4543a32
Compare
983a8a6
to
5e898eb
Compare
Changes:
Refactored image handling similar to #2800 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend.
Rationale:
The changes provide a more uniform and informative way to display image metadata, making it easier for users to understand the characteristics of selected container images.
What to check:
Data parsing is the same as 24.12.
Effects:
Users will see:
Screenshots:
Checklist: