Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: parsing image data in session launcher for before 24.12 #2818

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 5, 2024

Changes:
Refactored image handling similar to #2800 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend.

  • Unified the display format of image information across components
  • Added base version and image tags display
  • Replaced custom tag display with standardized ImageTags component
  • Removed conditional rendering based on extended image info support

Rationale:
The changes provide a more uniform and informative way to display image metadata, making it easier for users to understand the characteristics of selected container images.

What to check:
Data parsing is the same as 24.12.

Effects:
Users will see:

  • Consistent image information display format
  • Clearer representation of image base versions
  • Standardized tag display across the interface
  • More detailed image metadata including architecture and labels

Screenshots:

image.png

Checklist:

  • Documentation
  • Test cases to verify image information display
  • Verify tag display functionality across different image types

Copy link

graphite-app bot commented Nov 5, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:L 100~500 LoC label Nov 5, 2024
@agatha197 agatha197 added the type:refactor Refactoring current implementation. label Nov 5, 2024 — with Graphite App
@agatha197 agatha197 added this to the 24.09 milestone Nov 5, 2024
@agatha197 agatha197 requested a review from lizable November 5, 2024 14:30
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 0af5704 to c19e56e Compare November 5, 2024 14:39
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 28c8b39 to 9611d7d Compare November 5, 2024 14:39
@agatha197 agatha197 added the urgency:4 As soon as feasible, implementation is essential. label Nov 5, 2024
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from c19e56e to 7cb84bf Compare November 6, 2024 02:50
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 9611d7d to e12704a Compare November 6, 2024 02:50
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 7cb84bf to 6480068 Compare November 6, 2024 02:53
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from e12704a to b22b627 Compare November 6, 2024 02:53
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-before-2412 branch 2 times, most recently from 9500252 to 3708a1b Compare November 6, 2024 04:42
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from b22b627 to e256c11 Compare November 6, 2024 04:42
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 3708a1b to 1c990ef Compare November 6, 2024 04:59
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from e256c11 to 6445e5b Compare November 6, 2024 04:59
@agatha197 agatha197 mentioned this pull request Nov 6, 2024
6 tasks
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 1c990ef to ab1cca7 Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 6445e5b to 4f66088 Compare November 6, 2024 07:42
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from ab1cca7 to 775b8be Compare November 6, 2024 07:53
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 4f66088 to 3f70242 Compare November 6, 2024 07:54
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 775b8be to f81d39c Compare November 6, 2024 08:00
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

It can display duplicate tags. You can reproduce this by setting the endpoint to "cloud.backend.ai".
There are two "GPU:ooooo" tag

@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 3a506af to 71e0de8 Compare November 11, 2024 00:55
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 38fc810 to 5cb9459 Compare November 11, 2024 00:55
Copy link
Contributor Author

resolved!

@agatha197 agatha197 requested a review from yomybaby November 11, 2024 04:45
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 71e0de8 to 744604e Compare November 11, 2024 05:25
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 5cb9459 to 01d1980 Compare November 11, 2024 05:26
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 744604e to 7c8e7da Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 01d1980 to b814fbf Compare November 11, 2024 05:29
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 7c8e7da to 46489c7 Compare November 12, 2024 07:52
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from b814fbf to 162bc3b Compare November 12, 2024 07:52
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from 46489c7 to c8306dd Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 162bc3b to 4f68e12 Compare November 12, 2024 08:24
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-before-2412 branch from c8306dd to 6993177 Compare November 12, 2024 08:30
@agatha197 agatha197 force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch 2 times, most recently from 18df098 to 983a8a6 Compare November 12, 2024 08:36
@agatha197 agatha197 requested a review from yomybaby November 12, 2024 08:36
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Nov 12, 2024

Merge activity

)

**Changes:**
Refactored image handling similar to #2800 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend.

- Unified the display format of image information across components
- Added base version and image tags display
- Replaced custom tag display with standardized ImageTags component
- Removed conditional rendering based on extended image info support

**Rationale:**
The changes provide a more uniform and informative way to display image metadata, making it easier for users to understand the characteristics of selected container images.

**What to check:**
Data parsing is the same as 24.12.

**Effects:**
Users will see:
- Consistent image information display format
- Clearer representation of image base versions
- Standardized tag display across the interface
- More detailed image metadata including architecture and labels

**Screenshots:**

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/0a6100fd-d894-40d3-85d9-fe52961df2cf.png)

**Checklist:**
- [ ] Documentation
- [ ] Test cases to verify image information display
- [ ] Verify tag display functionality across different image types
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-before-2412 branch from 6993177 to 4543a32 Compare November 12, 2024 08:55
@yomybaby yomybaby force-pushed the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch from 983a8a6 to 5e898eb Compare November 12, 2024 08:55
Base automatically changed from refactor/parsing-image-data-before-2412 to main November 12, 2024 08:58
@graphite-app graphite-app bot merged commit 5e898eb into main Nov 12, 2024
4 checks passed
@graphite-app graphite-app bot deleted the refactor/parsing-image-data-in-session-launcher-for-versions-before-2412 branch November 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC type:refactor Refactoring current implementation. urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants