Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global breadcrumb #2847

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 13, 2024

Resolves #2841

Add WebUI NEO Breadcrumb Navigation Component

image.png

Adds a breadcrumb navigation component to the WebUI interface, providing users with clear path indication and navigation capabilities. The breadcrumb appears below the header and displays the current location hierarchy based on the route structure.

Key features:

  • Displays current navigation path with clickable links
  • Integrates with existing routing system
  • Supports internationalization (i18n) for labels
  • Maintains consistent styling with Ant Design theme tokens
  • Preserves navigation history for better user orientation

To review:

  1. Verify breadcrumb appears correctly on all pages
  2. Check navigation links work as expected
  3. Confirm proper i18n label rendering
  4. Validate styling consistency with design system

Copy link

graphite-app bot commented Nov 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:L 100~500 LoC label Nov 13, 2024
Copy link
Member Author

yomybaby commented Nov 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review November 13, 2024 07:42
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from fc6f867 to 9169a62 Compare November 14, 2024 01:15
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from d8f8b2c to 6dc04c2 Compare November 14, 2024 01:15
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete unused comments.

@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 6dc04c2 to e32499e Compare November 14, 2024 05:37
@yomybaby yomybaby requested a review from ironAiken2 November 14, 2024 05:37
@yomybaby yomybaby linked an issue Nov 14, 2024 that may be closed by this pull request
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from e32499e to 6535ff2 Compare November 14, 2024 06:35
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 9169a62 to b5ce6fd Compare November 15, 2024 03:36
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch 2 times, most recently from 552cd75 to 74b7589 Compare November 15, 2024 03:41
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from b5ce6fd to f13e145 Compare November 15, 2024 07:38
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 74b7589 to 7764966 Compare November 15, 2024 07:38
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from f13e145 to 3b1b867 Compare November 16, 2024 03:00
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 7764966 to 4aba93b Compare November 16, 2024 03:00
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 3b1b867 to 80fccdc Compare November 16, 2024 03:29
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 4aba93b to b704fce Compare November 16, 2024 03:29
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 80fccdc to 4b2abdc Compare November 17, 2024 00:19
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from b704fce to 7748272 Compare November 17, 2024 00:19
@ironAiken2 ironAiken2 force-pushed the feature/webui-link-and-navigate-component branch from 4b2abdc to 62d34f9 Compare November 18, 2024 05:28
@ironAiken2 ironAiken2 force-pushed the feature/breadcrumb-in-mainlayout branch from 7748272 to a59a8f9 Compare November 18, 2024 05:28
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 4b2abdc to d89a170 Compare November 19, 2024 09:39
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from a59a8f9 to 9848169 Compare November 19, 2024 09:40
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from d89a170 to 39796fa Compare November 20, 2024 06:53
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 9848169 to 456ddaf Compare November 20, 2024 06:53
Copy link

graphite-app bot commented Nov 20, 2024

Merge activity

Resolves #2841

# Add WebUI NEO Breadcrumb Navigation Component

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/1d58e4b9-385a-45e5-b4be-492fc61f1213.png)

Adds a breadcrumb navigation component to the WebUI interface, providing users with clear path indication and navigation capabilities. The breadcrumb appears below the header and displays the current location hierarchy based on the route structure.

Key features:
- Displays current navigation path with clickable links
- Integrates with existing routing system
- Supports internationalization (i18n) for labels
- Maintains consistent styling with Ant Design theme tokens
- Preserves navigation history for better user orientation

To review:
1. Verify breadcrumb appears correctly on all pages
2. Check navigation links work as expected
3. Confirm proper i18n label rendering
4. Validate styling consistency with design system
@yomybaby yomybaby force-pushed the feature/webui-link-and-navigate-component branch from 39796fa to aa466b1 Compare November 20, 2024 06:56
@yomybaby yomybaby force-pushed the feature/breadcrumb-in-mainlayout branch from 456ddaf to 17ea21a Compare November 20, 2024 06:57
@graphite-app graphite-app bot changed the base branch from feature/webui-link-and-navigate-component to feature/session-detail-panel-in-notifications November 20, 2024 06:58
Base automatically changed from feature/session-detail-panel-in-notifications to main November 20, 2024 07:01
@graphite-app graphite-app bot merged commit 17ea21a into main Nov 20, 2024
4 checks passed
@graphite-app graphite-app bot deleted the feature/breadcrumb-in-mainlayout branch November 20, 2024 07:02
@yomybaby yomybaby mentioned this pull request Nov 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainLayout NEO: Breadcrumb
2 participants