ci: Unify suffixes in release names the same way as before #3535
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Yaminyam
added
the
skip:changelog
| kernel_name_aliases = { | ||
| "linux": "linux", | ||
| "darwin": "macos", | ||
| "win32": "windows", | ||
| } | ||
|
|
||
| platform_kernel = kernel_name_aliases.get(sys.platform, sys.platform) |
There was a problem hiding this comment.
This seems likely to resolve the issue.
However, in the past, it seems that the name was matched without an alias. Do you know why the name has been changed?
There was a problem hiding this comment.
Previously, we were building with the SCIE plugin, but recently PEX included SCIE-based builds to replace that functionality.(ref. #3377)
There was an issue where if pantsbuild varied the output filename specified, pants would not recognize that it had output normally and would clean it up.
So we added scripts/get-platform-suffix.py to append the suffix after pantsbuild has finished.
There was a problem hiding this comment.
Could you please run the test and share the results?
There was a problem hiding this comment.
Yes I just ran a test locally.
resolves #3534 (BA-605)
I will also need to rename all of the release files for the 25.1.1 version that were incorrectly registered in this PR.
Checklist: (if applicable)