Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Unify suffixes in release names the same way as before #3535

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ci: Unify suffixes in release names the same way as before #3535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/get-platform-suffix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@
"i686": "x86", # Windows
}

platform_kernel = sys.platform
kernel_name_aliases = {
"linux": "linux",
"darwin": "macos",
"win32": "windows",
}

platform_kernel = kernel_name_aliases.get(sys.platform, sys.platform)
Comment on lines +14 to +20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems likely to resolve the issue.
However, in the past, it seems that the name was matched without an alias. Do you know why the name has been changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we were building with the SCIE plugin, but recently PEX included SCIE-based builds to replace that functionality.(ref. #3377)
There was an issue where if pantsbuild varied the output filename specified, pants would not recognize that it had output normally and would clean it up.
So we added scripts/get-platform-suffix.py to append the suffix after pantsbuild has finished.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the test and share the results?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-01-24 at 15 20 11@2x
Yes I just ran a test locally.

platform_arch = arch_name_aliases.get(platform.machine(), platform.machine())

print(f"{platform_kernel}-{platform_arch}")
Loading