Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#382 - Change display and translations structure for criteria and concepts #384

Conversation

michael-82
Copy link
Collaborator

  • remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored)
  • modify swagger file to match new responses
  • adapt tests to the new structure
  • Change responses to codeable concept and terminology replies to the new structure

@michael-82 michael-82 self-assigned this Oct 22, 2024
@michael-82 michael-82 linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (5792b49) to head (5b7638c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ty_gui_backend/terminology/TerminologyService.java 0.00% 7 Missing ⚠️
...i_backend/terminology/es/TerminologyEsService.java 55.55% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #384      +/-   ##
=============================================
- Coverage      78.54%   78.54%   -0.01%     
- Complexity       561      566       +5     
=============================================
  Files            138      140       +2     
  Lines           2419     2470      +51     
  Branches         149      151       +2     
=============================================
+ Hits            1900     1940      +40     
- Misses           461      472      +11     
  Partials          58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 force-pushed the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch from 57631fd to 77b8a15 Compare October 24, 2024 06:54
@michael-82 michael-82 force-pushed the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch from 77b8a15 to 8c9c7db Compare November 12, 2024 13:35
@michael-82 michael-82 force-pushed the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch from 8c9c7db to d0bc23f Compare December 6, 2024 08:21
@michael-82 michael-82 force-pushed the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch from 8b81ab4 to d395540 Compare January 14, 2025 15:07
…cepts

- remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored)
- modify swagger file to match new responses
- adapt tests to the new structure
- Change responses to codeable concept and terminology replies to the new structure
- change de-De to de and en-US to us for the elastic search related entries (the ones sent to the frontend are unchanged...might have to change as well)
- modify elastic search tests in integration tests
- remove GET of documents with fixed ids from elastic search integration test since those ids differ with each new ontology
- add translations to CriteriaProfileData
- adapt swagger file
@michael-82 michael-82 force-pushed the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch from 3ff801d to 5b7638c Compare January 15, 2025 12:41
@michael-82 michael-82 marked this pull request as ready for review January 15, 2025 12:41
@michael-82 michael-82 added the enhancement New feature or request label Jan 15, 2025
@michael-82 michael-82 merged commit 0c73e13 into develop Jan 15, 2025
8 checks passed
@michael-82 michael-82 deleted the feature/382-change-display-and-translations-structure-for-criteria-and-concepts branch January 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change display and translations structure for criteria and concepts
2 participants