-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a first figure to Modelica.Blocks.Examples.PID_Controller #4094
Conversation
I guess before such change can be accepted the MAP-LIB project first of all needs to have some strategic decision on what the next release is going to be and what MLS version it should be based on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Dymola 2023x Refresh1.
Co-authored-by: Thomas Beutlich <[email protected]>
This reverts commit c015bfc. Bumping language version is now made the separate PR modelica#4208.
With the bumping of Modelica language version now being done separately in #4208, I removed this part of the present PR, leaving just the first figure. |
Co-authored-by: tobolar <[email protected]>
@henrikt-ma Looking forward to use this widely! Any decission to use |
One consideration would be if there are multiple figures, I prefer not to have more than one preferred and usually have one preferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Discussed it in today's MAP-Lib meeting, will merge this, need a second reviewer |
@TManikantan please back-port this to the 4.1.0 alpha-branch |
@AHaumer the branch is deleted from the repo and I can't access it so all I could do is cherry pick that commit from master and then add it to the maint/4.1.0. but I don't know if that is a standard MSL work flow or even allowed to do it @henrikt-ma . As far as I know, you will still be having that branch in the local checkout, you can either push it directly to the maint/4.1.0 or to this repo and I shall look into adding it to the maint/4.1.0. |
I'm not sure we have developed routines for how to do this, but in case it helps, I have now restored the branch. |
First figure (cherry picked from commit d0ff9bc)
With love from the Modelica design meeting held this week:
This PR adds the first case of an example making use of the Modelica
Figure
annotation introduced in Modelica 3.5. Note that this means there are actually two important changes in this PR:PID_Controller
example.This is what the added figure looks like in System Modeler: