fix: Implement IGetDisplayNameBackend #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
bugfix/noid/user-backend-displayname-interface
branch
from
86ece90 to
253d71a
Compare
blizzz
reviewed
Oct 10, 2023
| @@ -328,7 +331,7 @@ public function getDisplayName($uid) { | |||
| } | |||
| } | |||
|
|
|||
| return false; | |||
| return $uid; | |||
There was a problem hiding this comment.
did you check internal usage of this method? are we somewhere expecting or acting specifically to false?
There was a problem hiding this comment.
All other user backends implement it that way. The interface actually requires a string type and doesn't allow boolean values anymore
There was a problem hiding this comment.
No doubt about this, my point was to double check we don't have odd internal behavior that relies on the false.
kesselb
reviewed
Oct 10, 2023
blizzz
force-pushed
the
bugfix/noid/user-backend-displayname-interface
branch
from
efeef61 to
0caf43f
Compare
blizzz
approved these changes
Oct 10, 2023
Signed-off-by: Julius Härtl <[email protected]>
blizzz
force-pushed
the
bugfix/noid/user-backend-displayname-interface
branch
from
0caf43f to
91e6004
Compare
|
Amended a fix to another static analysis finding https://github.com/nextcloud/user_saml/actions/runs/6473643774/job/17576817710?pr=771 |
|
@juliushaertl do we need a backport? |
|
/backport to stable5.2 |
|
/backport to stable-5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise instanceof checks like https://github.com/nextcloud/server/pull/38298/files#diff-2e1b245993621bf5efdce546bacce8f0e43efb7bc5d0c8d1b8a55f17231c4158R79 would fail