allows parameters when run a plugin subcommand #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Jorge Aguilera <[email protected]>
|
Thanks @jagedn! @bentsherman @tom-seqera thoughts? |
bentsherman
approved these changes
Jan 10, 2025
|
Some docs (?) tests are failing |
|
Should be fixed by the upstream changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't allow to pass tagged parameters when running a cmd plugin, only positional parameters are allowed (see #5084 )
This PR is a proposal to allow "--" as DynamicParameter so plugins can parse them.
For example, once the plugin receives the
String[]args, it can use JCommander and parse the arguments similar as core is doing right now so runningnextflow plugin my-plugin:my-command 1234 --f memory,module,namecan be the same as running
nextflow plugin my-plugin:my-command --f memory,module,name 1234