Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI params normalization #5661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bentsherman
Copy link
Member

Close #5655

Signed-off-by: Ben Sherman <[email protected]>
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 57f7e58
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/677ff1ec197bf00008b12c3f

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a test that validates the solution

@bentsherman
Copy link
Member Author

I have updated the tests accordingly

@pditommaso
Copy link
Member

Not following much, the issue says

I would expect to see this output (according to https://github.com/nextflow-io/nextflow/pull/4702):

[thingOne:newval]
newval
But instead I see this:

[thing-one:newval, thingOne:nothing]
nothing

I would expect, the test to validate the correct behaviour, instead only add quotes to some numeric values

@bentsherman
Copy link
Member Author

Check again, it also changed addParam0 to addParam in order to test the full behavior

@pditommaso
Copy link
Member

Continue to not understand how the test validates the fix for the defect reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI parameter case normalization/translation (kebab-case to camelCase) doesn't work at all since recent update
2 participants